How to deal with rejection - Pull Request wise π
After putting in a lot of work on my feature in Azure DevOps, I finally reached the point where I could create a pull request to merge it into the main branch. Since it was my first time doing this, I didn’t realize that my pull request could actually be rejected by the Project Manager! Luckily, I had been given some helpful tips beforehand, so while it wasn’t a perfect submission, it wasn’t completely rejected either. I just had to make a few changes based on the feedback. That experience got me thinking - dealing with rejection (even if it’s just a pull request) can be tough, so here’s what I learned about handling it constructively.
Steps to Success
1. Figure out why you got rejected - Typically you will have received some comments from reviewers which are crucial to understand in order to understand what went wrong - identifying this is the only way to then be able to address them. If the feedback isn't clear, reach out asking for clarification. The best way to do this is writing a comment in the Pull Request comments area itself as then this can be a chronological feedback and improvement record for future reference if needed.
2. Make amends and test them - Focus on each point of change needed, highlighted in the feedback - and work your way through them. When committing make sure you add clear messages that address each of the amends you made making it easier for the reviewer to identify these changes. And this may seem obvious but make sure to test the changes you made and also things that are linked to the changes you have made.
3. Submit your revised pull request and stay in touch - Once you are sure that you have amended what you needed to do, push your changes to the existing pull request branch and create a summative comment of your changes. After submitting, stay in touch, looking out for any more feedback - and most importantly don't take the rejecting too much to heart π